Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart test executions functionality #161

Merged
merged 18 commits into from
May 2, 2024

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented May 1, 2024

TO PR for resolving RTW-303. (there should still be a small PR on hwcert-jenkins-jobs to complement this)

Changes:

  • Adds a new table named test_execution_rerun_request
  • Adds a new endpoint /v1/test-executions/reruns that you can post to and get
  • API returns an additional field with test executions named is_rerun_requested
  • Delete and recreation of poetry.lock file to solve local dev environment not working. This required a new db migration and small modifications to a function in repository.py
  • Add a new script test_executions_rerunner.py that will be used in jenkins to actually perform those reruns (this way jenkins credentials stay in jenkins)
  • When PUT /v1/test-executions/start-test is called delete existing rerun request
  • Added rerun button to the frontend. This button is disabled if a rerun was requested already
Screencast.from.2024-05-01.16-53-58.webm

@omar-selo omar-selo force-pushed the restart-test-executions-functionality branch from 412a924 to ea09022 Compare May 1, 2024 10:43
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration was required after recreating poetry.lock

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were required after recreating poetry.lock

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this landed as it will be a really useful addition. I left two comments on how we can improve the code, but we can land this as it is.

frontend/lib/providers/artefact_builds.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for refactoring the common code in one!

@omar-selo omar-selo merged commit 843d373 into main May 2, 2024
3 of 4 checks passed
@omar-selo omar-selo deleted the restart-test-executions-functionality branch May 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants