-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart test executions functionality #161
Conversation
412a924
to
ea09022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration was required after recreating poetry.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were required after recreating poetry.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this landed as it will be a really useful addition. I left two comments on how we can improve the code, but we can land this as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for refactoring the common code in one!
TO PR for resolving RTW-303. (there should still be a small PR on hwcert-jenkins-jobs to complement this)
Changes:
test_execution_rerun_request
/v1/test-executions/reruns
that you can post to and getis_rerun_requested
poetry.lock
file to solve local dev environment not working. This required a new db migration and small modifications to a function inrepository.py
test_executions_rerunner.py
that will be used in jenkins to actually perform those reruns (this way jenkins credentials stay in jenkins)PUT /v1/test-executions/start-test
is called delete existing rerun requestScreencast.from.2024-05-01.16-53-58.webm