Adds confirmation dialog before accepting a rerun #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejvelichkovski
approved these changes
May 7, 2024
Comment on lines
+100
to
+120
| builder: (_) => AlertDialog( | ||
| title: const Text( | ||
| 'Are you sure you want to rerun this test execution?', | ||
| ), | ||
| actions: [ | ||
| TextButton( | ||
| autofocus: true, | ||
| onPressed: () { | ||
| ref | ||
| .read(artefactBuildsProvider(artefactId).notifier) | ||
| .rerunTestExecution(testExecution.id); | ||
| context.pop(); | ||
| }, | ||
| child: const Text('yes'), | ||
| ), | ||
| TextButton( | ||
| onPressed: () => context.pop(), | ||
| child: const Text('no'), | ||
| ), | ||
| ], | ||
| ), |
There was a problem hiding this comment.
Perhaps we can refactor this in a separate component, maybe a TestExecutionRerunAlertDialog to make the code a bit more structured?
There was a problem hiding this comment.
I would love to. That's actually how I started, a separate widget. But for some reason this line of code builder: () => TestExecutionRerunAlertDialog kept failing and returning an error. Something about missing Navigator context in parent widget IIRC. Tried to get it to work but it wouldn't budge. So I resorted to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://warthogs.atlassian.net/browse/RTW-306
Adds confirmation dialog before submitting a rerun request. This confirmation dialog can be accepted immediately by pressing enter.
Screencast.from.2024-05-06.12-58-59.webm