Rerun artefact test executions #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
force-pushed
the
keep-review-after-rerun
branch
from
7e6c59b to
9ab0b5e
Compare
omar-selo
force-pushed
the
rerun-artefact-test-executions
branch
from
7df6328 to
5b66de7
Compare
omar-selo
force-pushed
the
rerun-artefact-test-executions
branch
from
5b66de7 to
a2823a4
Compare
andrejvelichkovski
previously approved these changes
May 7, 2024
| RerunArtefactTestExecutionsRequest, | ||
| ) | ||
|
|
||
| router = APIRouter(tags=["artefacts"]) |
There was a problem hiding this comment.
Thanks for adding the tag here 😄
|
|
||
| class RerunArtefactTestExecutionsRequest(BaseModel): | ||
| test_execution_status: TestExecutionStatus | None = None | ||
| test_execution_review_decision: list[TestExecutionReviewDecision] | None = None |
There was a problem hiding this comment.
The review_decision is defined as a set in the TestExecutionDTO, although here it wouldn't really change a lot, if you want we can make it a set
| test_executions = (te for te in test_executions if te.status == status) | ||
| if (decision := request.test_execution_review_decision) is not None: | ||
| test_executions = ( | ||
| te for te in test_executions if te.review_decision == decision |
There was a problem hiding this comment.
If we don't define the review decision as a set maybe here we should do set comparison instead of list as the order doesn't really matter.
There was a problem hiding this comment.
ah very good point
andrejvelichkovski
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backend side of https://warthogs.atlassian.net/browse/RTW-307
Changes:
POST /v1/artefacts/<artefact-id>/rerunsthat allows user to rerun all test executions belonging to an artefactNote that CI will fail until we merge and rebase #172