Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to frontend #245

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Add images to frontend #245

merged 12 commits into from
Jan 20, 2025

Conversation

omar-selo
Copy link
Collaborator

Description

Changes:

  • Adds image artefacts page
  • Adds family specific artefact filters on each of snaps, debs, charms and images pages
  • Use null pattern for artefacts without an assignee and show N/A as assigned user if no user is assigned. This is useful because it allows us to filter artefacts without assignees, make the height of artefact card dynamic without handling the case of a no avatar having a smaller card, and show review progress even without an assignee

Resolved issues

Resolves https://warthogs.atlassian.net/browse/RTW-302 and https://warthogs.atlassian.net/browse/RTW-336

Documentation

None

Web service API changes

None

Tests

Tested manually as I didn't add any new functionality.

See below video:
Screencast from 2025-01-17 13-19-23.webm

@omar-selo omar-selo force-pushed the add-images-to-frontend branch from 6bdd5ff to f462b78 Compare January 17, 2025 10:22
@omar-selo omar-selo requested a review from rpbritton January 17, 2025 10:23
Copy link
Collaborator

@rpbritton rpbritton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the other one, straight forward with some good refactoring mixed in, nice! +1

@@ -82,30 +83,55 @@ class Filters<T> with _$Filters<T> {
}
}

final emptyArtefactFilters = Filters<Artefact>(
Filters<Artefact> createEmptyArtefactFilters(FamilyName family) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 refactoring

@omar-selo omar-selo merged commit 4d6016b into main Jan 20, 2025
2 checks passed
@omar-selo omar-selo deleted the add-images-to-frontend branch January 20, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants