Fix publish frontend workflow by specifying jammy instead of latest ubuntu #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejvelichkovski
approved these changes
Jan 20, 2025
| @@ -53,7 +53,7 @@ jobs: | |||
|
|
|||
| build-and-push-frontend-charm: | |||
| needs: build-and-push-frontend-image | |||
| runs-on: ubuntu-latest | |||
| runs-on: [self-hosted, linux, xlarge, jammy, x64] | |||
There was a problem hiding this comment.
Do the other options (all apart from jammy) guarantee that they will run jammy?
There was a problem hiding this comment.
Based on the GH documentation
If you specify an array of strings or variables, your workflow will execute on any runner that matches all of the specified runs-on values. For example, here the job will only run on a self-hosted runner that has the labels linux, x64, and gpu:
runs-on: [self-hosted, linux, x64, gpu]
the existence of jammy keyword ensures that the runner will be jammy. It's basically an "and" comparison not "or".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Charm builds on jammy so the runner building it must run jammy too.
Resolved issues
Fixes https://warthogs.atlassian.net/browse/RTW-427
Documentation
Web service API changes
Tests