Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text selectable #28

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Make text selectable #28

merged 3 commits into from
Jun 22, 2023

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented Jun 20, 2023

This resolves RTW-110. Specifically, it allows text on the frontend to be selectable. There is an issue however, the cursor turns into selectable cursor whenever pointing on text, even if this text was just the title of a button. So for buttons instead of having a click cursor we see a select cursor. I didn't find a simple workaround to this.

@omar-selo omar-selo requested a review from nadzyah June 20, 2023 08:34
@nadzyah
Copy link
Collaborator

nadzyah commented Jun 20, 2023

Should we do something with texts on buttons in this PR?

@omar-selo
Copy link
Collaborator Author

Should we do something with texts on buttons in this PR?

I looked around but didn't find a way to fix it. Flutter isn't great for the web. Alternatively, we could use SelectableText widget instead of Text widget everywhere except for buttons. Although the issue with this approach is that you cannot select text that spans multiple SelectableText widgets.

@nadzyah
Copy link
Collaborator

nadzyah commented Jun 21, 2023

I looked around but didn't find a way to fix it. Flutter isn't great for the web. Alternatively, we could use SelectableText widget instead of Text widget everywhere except for buttons. Although the issue with this approach is that you cannot select text that spans multiple SelectableText widgets.

Does it affect navbar as well?

@omar-selo
Copy link
Collaborator Author

Does it affect navbar as well?

Yes all buttons that have text

@nadzyah
Copy link
Collaborator

nadzyah commented Jun 21, 2023

Yes all buttons that have text

I guess it'll be pretty annoying not to be able to switch between families

@omar-selo
Copy link
Collaborator Author

I guess it'll be pretty annoying not to be able to switch between families

dw we can click on them just fine. It's just the cursor looks like the editor cursor not the click cursor

@nadzyah
Copy link
Collaborator

nadzyah commented Jun 21, 2023

dw we can click on them just fine. It's just the cursor looks like the editor cursor not the click cursor

If it is also okay to me to merge it with this bug. But it's better to create Jira or GH issue to fix it

@omar-selo omar-selo force-pushed the make-text-selectable branch from 2e79c4c to 2eaf41a Compare June 22, 2023 06:24
@omar-selo omar-selo merged commit eccded8 into main Jun 22, 2023
@omar-selo omar-selo deleted the make-text-selectable branch June 22, 2023 06:27
@omar-selo omar-selo mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants