Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return test-execution id from the /test-executions/start-test endpoint #29

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

nadzyah
Copy link
Collaborator

@nadzyah nadzyah commented Jun 20, 2023

This PR closes https://warthogs.atlassian.net/browse/RTW-109

Here I've done the following things:

  • Add response body for the /test-executions/start-test endpoint: {"id": <id>}
  • Rename /test-execution/start to /test-executions/start-test
  • Remove test-execution/ path to avoid misunderstandings. I've moved all the tests and implementation to the corresponding directory
  • Modify tests to check that the endpoint returns ID

@nadzyah nadzyah requested a review from omar-selo June 20, 2023 09:12
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a suggestion

@nadzyah nadzyah requested a review from omar-selo June 21, 2023 10:49
@nadzyah nadzyah merged commit bac60dc into main Jun 21, 2023
@nadzyah nadzyah deleted the return-test-exec-id branch June 21, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants