Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize project file structure #3

Merged
merged 13 commits into from
Mar 29, 2023
Merged

Conversation

omar-selo
Copy link
Collaborator

Initialize project structure of the Test Observer monorepo. Basically, whatever files were there, were moved into frontend directory. A new backend directory was created with a basic hello world server, file skeleton and a README. Also a new README was created for the whole monorepo. Note since I'm not on Jira I cannot link this PR to the original ticket.

@omar-selo omar-selo requested a review from nadzyah March 28, 2023 08:20
Copy link
Collaborator

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks for these changes! Just a minor thing I think we should change.

@omar-selo omar-selo requested a review from nadzyah March 28, 2023 09:51
@omar-selo omar-selo requested a review from nadzyah March 28, 2023 10:57
Copy link
Collaborator

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any other problems, good job! Don't forget to squash the commits :)

@omar-selo
Copy link
Collaborator Author

Thanks! I've added instructions on dependency management given that not everyone is familiar with Poetry

@omar-selo omar-selo requested a review from nadzyah March 28, 2023 12:58
@omar-selo omar-selo requested a review from nadzyah March 29, 2023 04:50
@omar-selo omar-selo merged commit 022ad1f into main Mar 29, 2023
@omar-selo omar-selo deleted the setup-project-file-structure branch March 29, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants