-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v0 data models #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Most of my comments are really for my information to get a better understanding of the details of what we're building
backend/alembic/versions/2023_05_02_1224-0332267421e8_add_basic_v0_models.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Omar Selo <omar.selo@canonical.com>
Co-authored-by: Omar Selo <omar.selo@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work!
* Add base v0 models * s/Page/Family and s/Lane/Stage * Fix typoes * Add more tests execution statuses * Update backend/src/data_access/models.py Co-authored-by: Omar Selo <omar.selo@canonical.com> * Update backend/src/data_access/models.py Co-authored-by: Omar Selo <omar.selo@canonical.com> * Use Association classes for M2M. Make Family-Environment relationship M2M * Make artefact name non-unique * Add duedate for artefacts * Remove redundant relations according to the spec --------- Co-authored-by: Omar Selo <omar.selo@canonical.com>
This PR resolves RTW-50
Here I've created the data models that are described in the CR021 excluding the "Comment" table because it requires the "User" table to be created as well, which is out of the scope of this PR.
I've used the Mapped class approach to map data types to python types. Also, all the relationships between tables are implemented based on this documentation
This PR contains migrations as well and they should be applied during deployment.