Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v0 data models #6

Merged
merged 10 commits into from
May 4, 2023
Merged

Add v0 data models #6

merged 10 commits into from
May 4, 2023

Conversation

nadzyah
Copy link
Collaborator

@nadzyah nadzyah commented Apr 21, 2023

This PR resolves RTW-50

Here I've created the data models that are described in the CR021 excluding the "Comment" table because it requires the "User" table to be created as well, which is out of the scope of this PR.

I've used the Mapped class approach to map data types to python types. Also, all the relationships between tables are implemented based on this documentation

This PR contains migrations as well and they should be applied during deployment.

@nadzyah nadzyah requested a review from omar-selo May 2, 2023 09:19
@nadzyah nadzyah marked this pull request as ready for review May 2, 2023 09:42
@nadzyah nadzyah requested a review from codersquid May 2, 2023 11:08
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Most of my comments are really for my information to get a better understanding of the details of what we're building

nadzyah and others added 3 commits May 2, 2023 15:48
Co-authored-by: Omar Selo <omar.selo@canonical.com>
Co-authored-by: Omar Selo <omar.selo@canonical.com>
@nadzyah nadzyah requested a review from omar-selo May 3, 2023 12:29
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@nadzyah nadzyah merged commit e988254 into main May 4, 2023
@nadzyah nadzyah deleted the data-model-v0 branch May 4, 2023 10:22
omar-selo added a commit that referenced this pull request May 8, 2023
* Add base v0 models

* s/Page/Family and s/Lane/Stage

* Fix typoes

* Add more tests execution statuses

* Update backend/src/data_access/models.py

Co-authored-by: Omar Selo <omar.selo@canonical.com>

* Update backend/src/data_access/models.py

Co-authored-by: Omar Selo <omar.selo@canonical.com>

* Use Association classes for M2M. Make Family-Environment relationship M2M

* Make artefact name non-unique

* Add duedate for artefacts

* Remove redundant relations according to the spec

---------

Co-authored-by: Omar Selo <omar.selo@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants