Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy UI #8

Merged
merged 8 commits into from
May 10, 2023
Merged

Dummy UI #8

merged 8 commits into from
May 10, 2023

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented May 8, 2023

PR for RTW-71. This is really just a dumb UI as in there is no functionality here and the data displayed is just dummy data and not even wired up properly.

This is how it looks like:
Screencast from 08-05-23 13:38:56.webm

@omar-selo omar-selo requested a review from nadzyah May 8, 2023 10:43
Copy link
Collaborator

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Especially that you've made it possible to scroll columns separately! I'm not familiar with flutter as much as you are, so I'm sorry if some comments are irrelevant.

frontend/lib/app.dart Show resolved Hide resolved
frontend/lib/dashboard/header.dart Show resolved Hide resolved
Copy link
Collaborator

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my questions were answered. Looks great!

@omar-selo omar-selo merged commit 1652bf2 into main May 10, 2023
@omar-selo omar-selo deleted the dummy-ui branch May 10, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants