Add a testflinger_common module with example usage #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boukeas
reviewed
May 21, 2024
boukeas
reviewed
May 21, 2024
boukeas
approved these changes
Jun 3, 2024
val500
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a very small (for now) testflinger_common project for housing things like enums which might be useful across multiple subprojects. I only provided example usage in the agent for now, but we can expand it to also be used by server, etc.
Resolved issues
N/A
Documentation
Not much to document at the moment for it, but I made sure to include a README.rst
Web service API changes
None, but using it in the server could help us to provide better guidance about the acceptable values for things like JobState.
Tests
Passes Unit testing, and also deployed it locally. Found a problem with specifying a branch to deploy for testing in the charm config where it still would only pull main previously. I fixed that also here as a separate commit.
Testing
Still not sure I understand why we have this section twice...