fix: Scrollbar should be in the side of the logview #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
approved these changes
Apr 9, 2024
|
Ugh, I don't feel like debugging this now - it's probably related to fluttercommunity/get_it#356. This shouldn't cause any issues elsewhere, since I'm not aware of a situation where we've registered multiple services of the same type, but we should definitely look into it and either pin |
It had a legit failure on another test too, but the pipeline had fail fast on the tests (turned off now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the scrollbar was within the padding, which looked really strange.
This also makes the scrollbar always visible when there is scrollable content.