Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MenuButtonBuilder only find render object when mounted #449

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: MenuButtonBuilder only find render object when mounted #449

merged 2 commits into from
Oct 14, 2024

Conversation

spydon
Copy link
Contributor

@spydon spydon commented Oct 14, 2024

In some cases you'll get the following without this fix applied:

This widget has been unmounted, so the State no longer has a context (and should be considered defunct).

@spydon spydon requested a review from d-loose October 14, 2024 09:01
@spydon spydon merged commit e72658f into main Oct 14, 2024
11 checks passed
@spydon spydon deleted the fix/dont-run-if-unmounted branch October 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-loose d-loose d-loose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @d-loose