Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade protobuf everywhere #1051

Merged
merged 2 commits into from
Jan 14, 2025
Merged

deps: Upgrade protobuf everywhere #1051

merged 2 commits into from
Jan 14, 2025

Conversation

CarlosNihelton
Copy link
Contributor

Upgrading protobuf usually cannot be done piecewise as CI fails for the packages not yet upgraded or which didn't have yet bindings regenerated.

As a result this closes #1033, #1047, #1048 and #1049.

@CarlosNihelton CarlosNihelton changed the title deps:Upgrade protobuf everywhere deps: Upgrade protobuf everywhere Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (2d1a28a) to head (64e39f6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   89.24%   89.20%   -0.04%     
==========================================
  Files         109      113       +4     
  Lines        7494     7534      +40     
==========================================
+ Hits         6688     6721      +33     
- Misses        628      637       +9     
+ Partials      178      176       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlosNihelton CarlosNihelton marked this pull request as ready for review January 14, 2025 17:44
@CarlosNihelton CarlosNihelton requested a review from a team as a code owner January 14, 2025 17:44
@CarlosNihelton CarlosNihelton requested review from ashuntu and removed request for a team January 14, 2025 17:44
Copy link
Collaborator

@ashuntu ashuntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarlosNihelton CarlosNihelton merged commit 67d65bd into main Jan 14, 2025
37 of 38 checks passed
@CarlosNihelton CarlosNihelton deleted the upgrade-protobuf branch January 14, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants