-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GROWENG-3818 changing legacy google analytics event to datalayer push #13954
GROWENG-3818 changing legacy google analytics event to datalayer push #13954
Conversation
laszlokajtar is not a collaborator of the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you fix
and we'll get this merged. |
@carkod i don't think i have the proper setup to run the repo locally, so prettier actually gives me an error. i'm not sure how it'd reformat what i have, is this something i could do manually? |
Unfortunately prettier doesn't output what needs to be fixed, there's a huge discussion about this, I'll push directly. |
This is a separate commit in order to guard from breaking previous commit
f1d9481
to
ffc8981
Compare
@laszlokajtar should be fixed now, can you check that everything looks good? Thanks. |
@carkod thank you! |
Done
QA
./run serve
ordotrun