Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROWENG-3818 changing legacy google analytics event to datalayer push #13954

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

laszlokajtar
Copy link
Contributor

Done

  • Replaced legacy Google Analytics scripts with dataLayer.push() scripts.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Upon the respective dyanmic form events, the dataLayer array contains the values specified in the code.

@webteam-app
Copy link

laszlokajtar is not a collaborator of the repo

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carkod
Copy link
Contributor

carkod commented Jun 18, 2024

Can you fix .js code formatting? Looking at this you probably just need:

prettier -w 'static/js/src/dynamic-forms.js'
prettier -w 'static/js/src/kernel-form.js'

and we'll get this merged.

@laszlokajtar
Copy link
Contributor Author

@carkod i don't think i have the proper setup to run the repo locally, so prettier actually gives me an error. i'm not sure how it'd reformat what i have, is this something i could do manually?

@carkod
Copy link
Contributor

carkod commented Jun 18, 2024

@carkod i don't think i have the proper setup to run the repo locally, so prettier actually gives me an error. i'm not sure how it'd reformat what i have, is this something i could do manually?

Unfortunately prettier doesn't output what needs to be fixed, there's a huge discussion about this, I'll push directly.

This is a separate commit in order to guard from breaking previous commit
@carkod carkod force-pushed the interactive-form-datalayer branch from f1d9481 to ffc8981 Compare June 18, 2024 12:31
@carkod
Copy link
Contributor

carkod commented Jun 18, 2024

@laszlokajtar should be fixed now, can you check that everything looks good? Thanks.

@laszlokajtar
Copy link
Contributor Author

@carkod thank you!

@carkod carkod merged commit 9ce39d3 into canonical:main Jun 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants