Increase the z-index for the navigation #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was so high it was overriding all things, including the greyed out overlay from the top menus.
Since the navigation needs to overlay practically everything, it should be high enough to provide plenty of lower layers for other things on the page that need to use z-index. I'm following a vague standard, which may be enshrined in team practices soon, that the page gets to use z-index in the range `0-50`, `51-100` should be reserved for plugins (like global-nav), and then `100+` should be used to override plugins if needed.
|
Starting demo at: https://www-ubuntu-com-canonical-websites-pr-4513.run.demo.haus/ |
anthonydillon
approved these changes
Dec 12, 2018
anthonydillon
added
Review: QA +1
Review: Code +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the navigation needs to overlay practically everything, it should be
high enough to provide plenty of lower layers for other things on the page
that need to use z-index.
I'm following a vague standard, which may be enshrined in team practices
soon, that the page gets to use z-index in the range
0-50,51-100should be reserved for plugins (like global-nav), and then100+should be used to override plugins if needed.So the nav uses
37-40, to sit near the top-end of that range, but with a little space above it.Fixes #4442
QA
./run serveCheck: