FrameSubmission: Expand test for Firefox frame storm. #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test checks that we don't generate a frame storm, but does *not* check that we actually send a frame callback, so simply dropping any of these requests on the floor passes. Add an extra test checking that we actually send these frame callbacks.
AlanGriffiths
approved these changes
Feb 7, 2025
| @@ -19,6 +19,7 @@ | |||
| #include "helpers.h" | |||
| #include "in_process_server.h" | |||
|
|
|||
| #include <functional> | |||
There was a problem hiding this comment.
The new code doesn't seem to need this, so why?
| */ | ||
| TEST_F(FrameSubmission, frame_requests_without_buffer_are_called_back_eventually) | ||
| { | ||
| std::array<bool, 5> called = {0}; |
There was a problem hiding this comment.
Relying on the implicit conversion to bool seems ugly
Suggested change
| std::array<bool, 5> called = {0}; | |
| std::array<bool, 5> called{false}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test checks that we don't generate a frame storm, but does not check that we actually send a frame callback, so simply dropping any of these requests on the floor passes.
Add an extra test checking that we actually send these frame callbacks.