Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trivy): Remove cron schedule #165

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix(trivy): Remove cron schedule #165

merged 2 commits into from
Nov 22, 2023

Conversation

merkata
Copy link
Contributor

@merkata merkata commented Nov 14, 2023

Applicable spec: n/a

Overview

Remove the cron job for removal of trivy CVEs.

Rationale

We don't want to run this against the fs, there is a PR that targets annotating the .trivyignore when the rock is built and scanned for vulnerabilities (that is the thing we want).

Juju Events Changes

n/a

Module Changes

n/a

Library Changes

n/a

Checklist

@merkata merkata added the trivial This is a trivial PR label Nov 14, 2023
@merkata merkata requested a review from a team as a code owner November 14, 2023 13:29
Copy link
Contributor

Test coverage for 758f496

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          530     41    172     31    89%   190-193, 357-358, 559, 590, 596, 641, 676-677, 728-735, 740, 842->847, 846, 848, 853-854, 914, 932, 939, 1029, 1038, 1050, 1071, 1080, 1099, 1103, 1132, 1185, 1317, 1339, 1346->1348, 1391->exit, 1403, 1419, 1456, 1465-1466
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 578     42    174     32    90%

Static code analysis report

Run started:2023-11-21 15:46:59.082849

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4298
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@merkata merkata merged commit ab1dbde into main Nov 22, 2023
25 checks passed
@merkata merkata deleted the fix/trivyignore branch November 22, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants