-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store and write proxy config to wp-config.php #171
Conversation
…ordpress-k8s-operator into store_and_write_proxy_config
Could you fill the PR description please? Out of curiosity: whats the impact if the proxy is not reachable? Is Wordpress still up? |
Hi, Thanks for the notice, I have updated the PR description with relevant information. Basically wordpress will be in a blocked state if the plugins|themes cannot be installed |
Technically the checkbox for " The PR is tagged with appropriate label (urgent, trivial, complex)" is checked though the PR is not labelled with any of those tags, could that please be resolved? |
github.com:canonical/wordpress-k8s-operator into store_and_write_proxy_config
Test coverage for 7c08317
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I labelled the PR appropriately, I also removed the |
During
_reconciliation
the charm checks if the themes and plugins currently installed matches the expected themes and plugin. If there are some missing the charm will then download them fromhttps://wordpress.org
. Behind the scene it runswp theme|plugin install
and If the charm is deployed behind a proxy and the proxy information is not present inwp-config.php
this command will fail, leaving the charm in a blocked state.This PR addresses that issue by fetching the proxy information from
juju model-config
and populate theproxy-config
attribute of the charm state so that the values can be added towp-config.php
during reconciliation.Checklist
src-docs
urgent
,trivial
,complex
)