-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default theme and plugin list inconsistency #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo-seijas
previously approved these changes
Nov 23, 2023
varshigupta12
previously approved these changes
Nov 23, 2023
weiiwang01
dismissed stale reviews from varshigupta12 and arturo-seijas
via
November 24, 2023 02:15
8981691
Test coverage for cedf252
Static code analysis report
|
Thanhphan1147
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mthaddon
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
WordPress charm defines a
_WORDPRESS_DEFAULT_THEMES
and_WORDPRESS_DEFAULT_PLUGINS
list containing all default installed themes and plugins in the workload image. These lists serve as the reference for theme and plugin management so it must alignment with themes and plugins within the OCI image.Update the two list to resolve problems caused by the inconsistency.
Reference for obtaining the lists of default themes and plugins:
Checklist
src-docs
urgent
,trivial
,complex
)