Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump evdev and lib versions #111

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

LinusCDE
Copy link
Collaborator

Evdev has gotten a new release which means we can now ship a working release of libremarkable again.

This will bump both the evdev version and the lib version. When merged I'll update the release on crates.io.

@LinusCDE
Copy link
Collaborator Author

Closes #106 and fixes the cause for #107.

@LinusCDE
Copy link
Collaborator Author

Would be cool if anyone can give it a quick 2nd glance. Will probably release it tomorrow or the following days then.

@fenollp
Copy link
Collaborator

fenollp commented Dec 10, 2022

LGTM! Feel free to go ahead :)

There's a warning in the CI about an unecessary mut, if you wan't to fix that as well.

Copy link
Collaborator

@bkirwi bkirwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A day to celebrate -- thanks!

@LinusCDE
Copy link
Collaborator Author

There's a warning in the CI about an unecessary mut, if you wan't to fix that as well.

Will add a fix for that quickly as well. :)

Will merge and update now.

@LinusCDE LinusCDE force-pushed the bump-evdev-and-lib-versions branch 2 times, most recently from 4b1994a to 8b6af6d Compare December 12, 2022 10:06
Seems that depending on what features are
built, ApplicationContext needs to be mut or
not. Explicitly allowing unused mut here to
cover those cases without complainin from the
compiler.
@LinusCDE LinusCDE merged commit 52dedd7 into canselcik:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants