Add support for the rM2 battery #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not tested. Though by viewing the file tree of /sys provided by @torwag (Eeems-Org/oxide#48 (comment) file tree.txt line 3166) it seems that all methods are supported.
|
looks good to me, shows 'Full - 99%'. I don't see anything about charging / discharging |
|
Thanks for testing! Seems to work then. I guess that "Full" is a third state I didn't know about meaning "would charge if battery allowed for it". It's just the file content of the sysfs battery interface. This PR is then mergable in my opinion since it is now tested on an actual rM 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message: This was not tested. Though by viewing the file tree of /sys provided by @torwag here (file tree.txt line 3166) it seems that all methods are supported.
I didn't test whether this actually works on a rM 2 as I don't own that device. I'm confident though that it should work. I added the compiled demo binary that also reports that battery data. Please test whether it displays Charging/Discharging and the percentage on the reMarkable 2.