Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Roboto optional #90

Merged
merged 3 commits into from
Jan 13, 2022
Merged

make Roboto optional #90

merged 3 commits into from
Jan 13, 2022

Conversation

LoganDark
Copy link
Contributor

This means you won't pay the cost of

  • font storage in the binary
  • up-front font parsing at runtime
  • storage of the parsed structures at runtime

if you don't use the built-in font drawing code.

@LoganDark LoganDark marked this pull request as draft January 13, 2022 02:11
@LoganDark
Copy link
Contributor Author

I'll test in a minute

@LoganDark LoganDark marked this pull request as ready for review January 13, 2022 02:16
LinusCDE
LinusCDE approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo runs fine

@LinusCDE LinusCDE merged commit da9fe2e into canselcik:master Jan 13, 2022
@LoganDark LoganDark deleted the optional-font branch January 13, 2022 19:01
fenollp added a commit to fenollp/libremarkable that referenced this pull request Jan 14, 2022
@fenollp
Elide some leftover impl lifetimes after PR canselcik#90
dd1b1f3 
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp fenollp mentioned this pull request Jan 14, 2022
Merged
bkirwi added a commit that referenced this pull request Jan 14, 2022
@bkirwi
Merge pull request #91 from fenollp/pr90plus
a20e0f0 
Elide some leftover impl lifetimes after PR #90
@LinusCDE LinusCDE added this to the 0.6.0 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusCDE LinusCDE LinusCDE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LoganDark @LinusCDE