Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Open Folder' and 'Browse' buttons missing #281

Closed
norgeous opened this issue Jun 17, 2016 · 7 comments
Closed

'Open Folder' and 'Browse' buttons missing #281

norgeous opened this issue Jun 17, 2016 · 7 comments

Comments

@norgeous
Copy link

Syncthing: v0.13.7
SyncTrayzor: 1.1.10

Hi @canton7!

I think recent changes may have broken the in-GUI 'Browse' and 'Open Folder' buttons. It would be nice to have these awesome feature returned at some point, so I thought I'd open a bug. Hopefully you see this also...

I'm not sure of the exact cause but I can explain some of the recent changes that may be related if you think it might help?

I had a look in ViewerViewModel.cs and the jQuery selects look like they still match. I'm really not sure what's happening because it feels like parts of this injected jQuery run (such as $('#directory-list').remove();) but other parts don't (such as the Browse button).

Also, there have been many recent improvements to the #directory-list (in Add Folder > Folder Path) which you are removing... maybe you could consider including this list with the button also? I don't think these two features (button and list) counteract each other.

@norgeous
Copy link
Author

I just tried with SyncTrayzor Portable and buttons appear fine. I wonder what's happening, maybe its just my setup.

@scienmind
Copy link
Contributor

Occasionally the buttons do disappear, and then reappear.
I've never got around to figuring out what an accurate pattern of this behavior is, but what you are describing is definitely familiar.

@canton7
Copy link
Owner

canton7 commented Jun 17, 2016

There's something racey where the javascript stuff sometimes doesn't get run. It's pretty rare, and refreshing the browser usually fixes it.

I haven't tested your new stuff yet. Bear in mind that CEF doesn't support the mechanism by which the old directory browser worked (I can't remember which html tag it used off the top of my head), which is why I removed it. Have you changed how it works fundamentally?

@norgeous
Copy link
Author

It still uses <datalist id="directory-list"></datalist>. It's unfortunate that...

CEF doesn't support the mechanism

I guess CEF != chrome. CEF#906

Yep, with refreshing I get a mixture of showing and not...

@canton7
Copy link
Owner

canton7 commented Jun 17, 2016

I can't remember when that javascript is run (I'm on mobile). It might be that it's running too early: might need to hook it into some event when the folders load?

I'm afraid I'm unlikely to get access to a computer for the next week.

@norgeous
Copy link
Author

It's ok, enjoy your time away! I'll close this for now.

@canton7
Copy link
Owner

canton7 commented Jun 17, 2016

Nah leave it open, otherwise I'll forget...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants