Skip to content

Comments

Update REVIEW_FEEDBACK.md for clarity on resumability#1

Open
haiyuan-eng-google wants to merge 1 commit intocaohy1988:feature/durable-session-persistencefrom
haiyuan-eng-google:patch-4
Open

Update REVIEW_FEEDBACK.md for clarity on resumability#1
haiyuan-eng-google wants to merge 1 commit intocaohy1988:feature/durable-session-persistencefrom
haiyuan-eng-google:patch-4

Conversation

@haiyuan-eng-google
Copy link

Revise document to acknowledge existing resumability features and position the proposal as an extension rather than a replacement. Update sections to reflect actual gaps and include cost estimation, monitoring, and rollback strategies.

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

Revise document to acknowledge existing resumability features and position the proposal as an extension rather than a replacement. Update sections to reflect actual gaps and include cost estimation, monitoring, and rollback strategies.
caohy1988 added a commit that referenced this pull request Feb 22, 2026
…k gaps

- Roadmap Phase 2 now targets Option A (persistent process) directly
  instead of cumulative replay (Option C) first
- Unify recovery policy: timeout and crash both return error indicating
  state loss, no automatic replay (consistent across §4.2.3 and §9)
- Add Windows NotImplementedError gate to LocalSandboxCodeExecutor
- Guard resource import in 3.10 preexec_fn fallback path
- Document that PermissionError → container.restart() is the primary
  timeout path in practice (container runs as root, ADK as non-root)
- Add explicit test cases for PermissionError fallback and kill paths
- Update open question #1 to focus on I/O boundary protocol design

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant