-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser CI Setup #1152
Browser CI Setup #1152
Conversation
'se-port': 4445, | ||
logfile: 'testingbot_tunnel.log' | ||
}, | ||
public: 'public' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be public: true
Why don't we test Firefox/Safari/IE instead of Chrome for now. I've messed around with CI systems in the past, and have noticed that Chrome will randomly hang in a containerized environment occasionally. We get pretty good V8 coverage through node. |
@aearly having similar issues with the queue tests in Firefox and Safari. I notice these tests are using a bunch of setTimeouts. Could the issue be that the vm is slower than expected? |
Bah, debugging tests that only fail in a CI browser environment is one of my personal visions of hell. Yes, it's very possible that the |
}, | ||
'TB_Edge': { | ||
base: 'TestingBot', | ||
browserName: 'microsoftedge' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Duplicate Edge entry.
Shall I close this? Seems really out of date. |
Em... I still want to get this in. It just sort of needs #1322 to be resolved. Guess its probably fine to close for now and work on later. |
I'm going to leave the branch hanging around though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check
This sets up browser continuous integration and fixes #923.
Some issues I've encountered in this configuration:
@aearly email me/ping me on gitter if you want testingbot keys to run tests locally