Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser CI Setup #1152

Closed
wants to merge 4 commits into from
Closed

Browser CI Setup #1152

wants to merge 4 commits into from

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented May 10, 2016

This sets up browser continuous integration and fixes #923.

Some issues I've encountered in this configuration:

  • parallel tests will sometimes fail without karma/mocha catching it properly, causing tests to stall

  • Queue pause tests often error.

@aearly email me/ping me on gitter if you want testingbot keys to run tests locally

'se-port': 4445,
logfile: 'testingbot_tunnel.log'
},
public: 'public'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be public: true

@aearly
Copy link
Collaborator

aearly commented May 10, 2016

Why don't we test Firefox/Safari/IE instead of Chrome for now. I've messed around with CI systems in the past, and have noticed that Chrome will randomly hang in a containerized environment occasionally. We get pretty good V8 coverage through node.

@megawac
Copy link
Collaborator Author

megawac commented May 10, 2016

@aearly having similar issues with the queue tests in Firefox and Safari. I notice these tests are using a bunch of setTimeouts. Could the issue be that the vm is slower than expected?

@aearly
Copy link
Collaborator

aearly commented May 12, 2016

Bah, debugging tests that only fail in a CI browser environment is one of my personal visions of hell.

Yes, it's very possible that the setTimeouts are much slower than anticipated. I would love to figure out a way to test that didn't rely on timings at all. One long GC pause, or any other CPU hang, and everything goes out the window.

},
'TB_Edge': {
base: 'TestingBot',
browserName: 'microsoftedge'
Copy link
Contributor

@jdalton jdalton May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Duplicate Edge entry.

@megawac megawac mentioned this pull request May 18, 2016
@megawac megawac mentioned this pull request Nov 13, 2016
@aearly
Copy link
Collaborator

aearly commented Apr 9, 2017

Shall I close this? Seems really out of date.

@megawac
Copy link
Collaborator Author

megawac commented Apr 9, 2017

Em... I still want to get this in. It just sort of needs #1322 to be resolved. Guess its probably fine to close for now and work on later.

@megawac megawac closed this Apr 9, 2017
@megawac
Copy link
Collaborator Author

megawac commented Apr 9, 2017

I'm going to leave the branch hanging around though.

Copy link

@ferdian26 ferdian26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check

@aearly aearly deleted the browser-ci branch May 19, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI browser testing/ Browser support
5 participants