Merge pull request #225 from ibash/fix_nil_and_async_consumer

Don't pause consumer if the value is nil. Fixes #173.
caolan · Feb 11, 2015 · f23493f · f23493f
2 parents 1964531 + 0f81418
commit f23493f
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -1040,7 +1040,8 @@ Stream.prototype.consume = function (f) {
         next_called = false;
         f(err, x, push, next);
         async = true;
-        if (!next_called) {
+        // Don't pause if x is nil -- as next will never be called after
+        if (!next_called && x !== nil) {
             s.pause();
         }
     };

diff --git a/test/test.js b/test/test.js
@@ -288,6 +288,27 @@ exports['async consume'] = function (test) {
     });
 };
 
+exports['consume - push nil async (issue #173)'] = function (test) {
+    test.expect(1);
+    _([1, 2, 3, 4]).consume(function(err, x, push, next) {
+        if (err !== null) {
+            push(err);
+            next();
+        }
+        else if (x === _.nil) {
+            _.setImmediate(push.bind(this, null, x));
+        }
+        else {
+            push(null, x);
+            next();
+        }
+    })
+    .toArray(function (xs) {
+        test.same(xs, [1, 2, 3, 4]);
+        test.done();
+    });
+};
+
 exports['passing Stream to constructor returns original'] = function (test) {
     var s = _([1,2,3]);
     test.strictEqual(s, _(s));