Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] distribute the browserified highland with the NPM package #309

Closed
sethkinast opened this issue May 27, 2015 · 5 comments · Fixed by #310
Closed

[request] distribute the browserified highland with the NPM package #309

sethkinast opened this issue May 27, 2015 · 5 comments · Fixed by #310

Comments

@sethkinast
Copy link
Contributor

We use NPM to manage both Node modules and browser packages, instead of Bower.

It would be great if the dist folder could be distributed as part of the NPM package, instead of just lib.

@pajtai
Copy link

pajtai commented Jan 29, 2016

Just curious why don't require it in?

I use browserify too, and this is my workflow:

var highland = require('highland');

@Announcement
Copy link

@pajtai because that's not documented...

@vqvu
Copy link
Collaborator

vqvu commented Feb 14, 2016

@Announcement, can you clarify exactly what behavior is undocumented? Is it the ability to browserify a project that require('highland')? We can fix the documentation if it is missing something.

@pajtai
Copy link

pajtai commented Feb 15, 2016

I think it's implied from the homepage: http://highlandjs.org/

The high-level streams library for Node.js and the browser.

$ npm install highland

as in, saying it's for the browser and then showing an npm command implies it works with browserify, the way browserify is meant to work - by just requiring npms in on the browser.

@jeromew
Copy link
Collaborator

jeromew commented Feb 15, 2016

The doc also states "You can also integrate highland in your own browserify bundle using a classical browserify workflow, but this is beyond the scope of this documentation."

@vqvu vqvu closed this as completed in #310 Mar 24, 2016
vqvu added a commit that referenced this issue Mar 24, 2016
Distribute the browserified module as part of the NPM package. Closes #309.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants