Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge / mergeWithLimit inconsistency #475

Closed
Flygsand opened this issue Apr 7, 2016 · 3 comments
Closed

merge / mergeWithLimit inconsistency #475

Flygsand opened this issue Apr 7, 2016 · 3 comments
Labels

Comments

@Flygsand
Copy link

Flygsand commented Apr 7, 2016

Consider the following code:

function readFile(name) {
  return _(fs.createReadStream(name));
}

_(['foo', 'bar'])
  .map(readFile)
  .merge()
  .errors(function() {})
  .each(_.log);

The intent is to read whatever we can, ignoring any I/O errors, and this works. Calling mergeWithLimit instead of merge will cause errors to be thrown instead, which I didn't expect.

@vqvu vqvu added the bug label Apr 7, 2016
@vqvu
Copy link
Collaborator

vqvu commented Apr 8, 2016

Should be fixed in #476. Can you confirm?

@Flygsand
Copy link
Author

Flygsand commented Apr 8, 2016

Yes, I can confirm that it now works. Thanks for the quick response.

@vqvu vqvu closed this as completed in 3bc2398 Apr 8, 2016
@vqvu
Copy link
Collaborator

vqvu commented Apr 8, 2016

v2.7.4 released containing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants