New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mergeWithLimit should not throw error if source has error. Fixes #475. #476

Merged

vqvu merged 1 commit into caolan:master from vqvu:mergeWithLimit-emit-error

Apr 8, 2016

Collaborator

vqvu commented Apr 8, 2016

We used to get a

events.js:72
        throw er; // Unhandled 'error' event
              ^

error when a source emits errors due to listening for the end event without doing so for the error event.


          mergeWithLimit should not throw error if source has error.

ced46c1

vqvu mentioned this pull request

merge / mergeWithLimit inconsistency #475

Closed

Collaborator

svozza commented Apr 8, 2016

LGTM.

vqvu merged commit 3bc2398 into caolan:master

vqvu deleted the mergeWithLimit-emit-error branch

April 8, 2016 17:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet