Pausing a rate-limited stream doesn't work

[fmvilas]

Hi,

I've been trying the following code:

const highland = require('highland');
const { Writable } = require('stream');

const writable = new Writable({
  objectMode: true,
  write(chunk, encoding, callback) {
    console.log('=>', chunk.toString());
    callback();
  },
});

const stream = highland(['a', 'b', 'c', 'd']).ratelimit(1, 1000);

setTimeout(() => {
  console.log('Pausing...');
  stream.pause();
}, 2000);
setTimeout(() => {
  console.log('Resuming...');
  stream.resume();
}, 6000);
stream.pipe(writable);

But what I've found is that a rate-limited stream doesn't pause. Is it an expected behavior?

Thanks!

[vqvu]

This is a bug in 2.x, but it seems complicated to fix, and I don't have a lot of bandwidth to chase this down (the 2.x core has a lot of cruft that makes it hard to understand this kind of behavior). Can you use the 3.0 beta (npm install highland@next) instead?

[fmvilas]

Cool! It works with highland@next. I've been looking at the source code and definitely is a tough problem. From my side is ok to upgrade so no need to spend time fixing old stuff. Feel free to close the issue.

Thanks for your time and work!