_.streamifyAll #226
_.streamifyAll #226
Conversation
- test - useful for utilizing libraries like mongoose
- streamifies function properties - streamifies constructor prototype function properties
Conflicts: lib/index.js test/test.js
- motivated by use with mongoose
| } | ||
| } catch (e) {} | ||
| }; | ||
| while (Object.getPrototypeOf(curr)) { |
There was a problem hiding this comment.
I'm not sure how big a deal it is but IE8 doesn't support Object.getPrototypeOf. According to the package.json file we're supposed to support that browser.
There was a problem hiding this comment.
As far as I know I need to use Object.getPrototypeOf or __proto__ in order to support streamifying inherited methods, both of which are es5 features. However, I do check for es5 support (which as you point out IE8 is missing) and I don't call this function if we're missing it.
There was a problem hiding this comment.
Ah yes, I misread that bit at the end!
|
First off, this is very cool. I won't have time to look in-depth at this (so someone else should!), but a few comments. First, can you rebase against the current master? Your changelist looks a little weird. For instance, why is 2dcdc6e part of the changes? Second, can you move the helper functions to global scope? Put them in a |
|
My preference is to have the helper functions in the global scope of streamifyAll.js and any shared helpers in a utils.js. I'll try and refactor/rebase later today! |
|
Close in favor of #241. |
|
Oops. #242. |
At the suggestion of @LewisJEllis I've written a preliminary streamifyAll implementation, the highland equivalent of bluebird's promisifyAll.
On top of the included unit tests I did some manual integration tests with mongoose and I didn't run into any problems.
It might be worth adding options for custom filters, streamifiers, and suffixes as offered in bluebird.
Thanks