Tidy up support for drop() PR #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var s = _(function (push, next) { | ||
| push(null, 1), | ||
| push(new Error('Drop error')), | ||
| push(null, 2), |
There was a problem hiding this comment.
Is it me, or is the spacing off around here?
tidy up error handling and tests add no value on error test fix docs and no value on error test add note about error handling
svozza
force-pushed
the
tidy-up-support-drop
branch
from
313aa1b to
1dbfad6
Compare
|
All tidied up. |
| @@ -2372,6 +2371,43 @@ Stream.prototype.take = function (n) { | |||
| exposeMethod('take'); | |||
|
|
|||
| /** | |||
| * Acts as the inverse of `take(n)` - instead of returning the first `n` values, it ignores the | |||
There was a problem hiding this comment.
Put a link to the take docs here? [take](#take).
There was a problem hiding this comment.
Yeah, makes sense given that they're not beside each other in the docs.
|
OK. This looks good to me. Thanks @alexbeletsky and @svozza. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the few minor outstanding issues on #75 to resolve #11