Adds sort stream transformation incl. tests #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds noValueErrorTest for sort split sort into sort and sortBy
|
Does anyone have time to take a look at this? Would be good to get rid of one of the last 6+ month old PRs. |
|
This looks good. Something to think about is that this buffers the entire stream before sorting. We could do an online insertion sort, but it's a speed/memory tradeoff: insertion sort would use O(n²) memory but do the sort while streaming which is probably more efficient. I think we should go ahead with this pull request and maybe revisit this in the future with benchmarks. |
|
Yeah, we could build up the sorted array with a binary insert or something. Could definitely be a nice way of doing it if the benchmarks warrant it. |
|
On the other hand, I trust the build-in sort much better than anything I could write. I'll go ahead and merge this. |
apaleslimghost
added a commit
that referenced
this pull request
Mar 18, 2015
Adds sort stream transformation incl. tests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #169
adds noValueErrorTest for sort
split sort into sort and sortBy