Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap arg order of reduce and rename zip functions #351

Merged
merged 1 commit into from
Jul 28, 2015
Merged

swap arg order of reduce and rename zip functions #351

merged 1 commit into from
Jul 28, 2015

Conversation

svozza
Copy link
Collaborator

@svozza svozza commented Jul 28, 2015

As per #179, reorder the arguments in reduce and scan to make them iterator first and rename zipAll to zipEach and zipAll0 to zipAll.

@vqvu vqvu added this to the 3.0.0 milestone Jul 28, 2015
vqvu added a commit that referenced this pull request Jul 28, 2015
@vqvu
Merge pull request #351 from svozza/reorder-reduce-rename-zips
4123a0a 
Swap arg order of reduce and rename zip functions.
@vqvu vqvu merged commit 4123a0a into caolan:3.0.0 Jul 28, 2015
@vqvu
Copy link
Collaborator

vqvu commented Jul 28, 2015

I forgot about this, but what about pickBy's callback argument order?

@svozza
Copy link
Collaborator Author

svozza commented Jul 28, 2015

Yeah, should we change it to fn(val, key)? I can do a separate PR for that.

@vqvu
Copy link
Collaborator

vqvu commented Jul 28, 2015

Yeah. I think that's the change we want.

@svozza svozza mentioned this pull request Jul 28, 2015
Merged
@svozza svozza deleted the reorder-reduce-rename-zips branch July 28, 2015 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@svozza @vqvu