Keep a reference to the correct consumer/observer array in _send (resolves #366). #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vqvu
force-pushed
the
consume-mutates-consumers
branch
from
a74b6e5
to
f54a591
Compare
|
Ref #366. |
|
@jgrund Looks like we did our work in parallel. This is basically the same fix you had but with tests that will work when I merge into 3.0.0. |
vqvu
added a commit
that referenced
this pull request
Sep 7, 2015
Keep a reference to the correct consumer/observer array in _send (resolves #366).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We iterate through the
_consumersand_observersarrays in_send, but the the arrays may be modified during iteration, so we need to keep a copy of the original reference around.