Properly exert backpressure for pipeline-constructed streams. #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #371 (comment).
pipeline
overrides thewrite
method but doesn't return anything. For node streams, this has the effect of disabling backpressure, since they do a check forfalse === write(...)
. For others, it may have the effect of always enabling backpressure.We need to return the correct value. This also means supporting the
drain
event, which it didn't before.My solution was to
_()
,write
to returnsrc.write(x)
, andpipe
dest
to the result stream.In the process, I refactored the logic for
pipe
out into a separate function that is used by bothpipeline
andpipe
(with slightly different behavior).This was actually more complicated than I thought, so I'd like some eyes on this besides my own.