Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to eslint@1.9.0. #387

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Update to eslint@1.9.0. #387

merged 1 commit into from
Nov 12, 2015

Conversation

vqvu
Copy link
Collaborator

@vqvu vqvu commented Nov 12, 2015

Updates eslint from 0.10.0 to 1.9.0 and grunt-eslint from 2.1.0 to 17.3.1 (!).

I followed the migration guide here: http://eslint.org/docs/user-guide/migrating-to-1.0.0 and sorted all rules in lexical order, with the no-* rules placed at the start.

@svozza, I had issues installing the new eslint at first too. It seems to be an npm bug though, since updating to npm@1.4.28 fixed it. Edit: I went back to my old version and it still works...not sure what the problem was.

@LewisJEllis
Copy link
Collaborator

Looks good. ESLint has come a long way this year!

LewisJEllis added a commit that referenced this pull request Nov 12, 2015
@LewisJEllis LewisJEllis merged commit 07933ba into caolan:master Nov 12, 2015
@svozza
Copy link
Collaborator

svozza commented Nov 12, 2015

Yeah, the errors I was seeing we're coming from no* rules. All working now.

@vqvu
Copy link
Collaborator Author

vqvu commented Nov 12, 2015

Yeah, there was one: no-inner-declarations, that I had to turn off because we had inner function and var declarations everywhere.

@vqvu vqvu deleted the update-eslint branch November 12, 2015 18:03
@vqvu vqvu added this to the v2.6.0 milestone Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants