Fix destroyed fork backpressure. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * that only works for integer keys. | ||
| */ | ||
| function IntMap() { | ||
| this.map = {}; |
There was a problem hiding this comment.
Not sure if there's much point but you could reuse isES5 in index.js to see whether you could use Object.create(null) here.
There was a problem hiding this comment.
I didn't do it because I'm using Object.prototype.hasOwnProperty. Is there a perf improvement to doing Object.create(null)?
There was a problem hiding this comment.
The perf gain is in not having to do the hasOwnProperty check but tbh like most micro-optimisations I doubt it's worth the hassle.
There was a problem hiding this comment.
Ah, gotcha. Agreed that it's not worth the hassle. Modern browsers and Nodes will just end up using global.Map anyway.
|
Very nice implementation. |
svozza
added a commit
that referenced
this pull request
Nov 28, 2015
Fix destroyed fork backpressure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #179 (comment) for description.