Make pipe behave more like Readable#pipe. Fixes #449. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `pipe` now emits the `pipe` event on the destination when piping. - `pipe` has an optional pipe options argument that allows users to choose to not end the destination when the source ends.
vqvu
force-pushed
the
pipe-event-and-pipe-options
branch
from
5854a1b to
25f8051
Compare
|
Awesome! This will enable me to remove a lot of workarounds! |
|
Seems to be no objections...I will merge. |
vqvu
added a commit
that referenced
this pull request
Feb 13, 2016
Make pipe behave more like Readable#pipe. Fixes #449.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe didn't support all of the behaviors of
Readable#pipe, which results in annoying bugs. This brings it more in line.pipenow emits thepipeevent on the destination when piping.pipehas an optional pipe options argument that allows users tochoose to not end the destination when the source ends.
The second argument to
pipeis optional, and generally we don't put optional arguments in stream transforms. However, sincepipeis meant for interop, there's a bigger win in making it mimic the node stream interface.