Fix possible memory leak in pipe. #466

vqvu · 2016-03-12T02:45:09Z

Destructors weren't being called, so the 'drain' handlers weren't being
unbound.

svozza · 2016-03-12T08:43:14Z

Nice. I find this code easier to follow that what was there before.

Destructors weren't being called, so the 'drain' handlers weren't being unbound.

vqvu added this to the 2.7.2 milestone Mar 12, 2016

vqvu mentioned this pull request Mar 12, 2016

Q - Stream not ended causes memory leak? #465

Closed

vqvu force-pushed the pipe-memory-leak branch from efd0107 to a136327 Compare March 12, 2016 10:47

vqvu added 3 commits March 30, 2016 18:37

Fix possible memory leak in pipe.

b04c01b

Destructors weren't being called, so the 'drain' handlers weren't being unbound.

Don't clear source and delegate twice.

ffd9a50

Make sure that we don't miss consumers when executing _onEnd.

63dfb17

vqvu force-pushed the pipe-memory-leak branch from 70d9b2b to 63dfb17 Compare March 31, 2016 00:37

vqvu merged commit e7b1bf8 into caolan:master Mar 31, 2016

vqvu removed this from the 2.7.2 milestone Mar 31, 2016

vqvu deleted the pipe-memory-leak branch April 29, 2016 05:23

Provide feedback