add _.of and _.fromError

[svozza]

As discussed in #519.

[vqvu]

push(null, _.nil)

[svozza]

Doh!

[vqvu]

LGTM.

[vqvu]

Can you add a short entry to the CHANGELOG.md referencing this change?

[svozza]

Oh yes, of course.

[svozza]

Done.

[svozza]

I've just realised, have I made this function too dumb, i.e., should I check to see if what I've got is a Promise or an Iterable and not wrap those objects in [] before passing them to the Highland constructor?

[vqvu]

I don't think so, for three reasons

1. Arrays are Iterables, and it seems weird to have to say _.of([[1, 2, 3]]) to get a stream of arrays. It's not very intuitive.
2. You could argue for promises, but that functionality may be better off
   implemented as part of asyncify instead. People already have _ if they
   know for sure that they have a promise.
3. Special cases would permanently break compatibility with fantasy land's
   definition of of.

On Tue, Aug 9, 2016 at 10:59 AM, Stefano Vozza notifications@github.com
wrote:

I've just realised, have I made this function too dumb, i.e., should I
check to see if what I've got is a Promise or an Iterable and not wrap
those objects in [] before passing them to the Highland constructor?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#520 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGIyZd7zwtG7T6dRUXN-qWa_rSN-ZIFfks5qeKPmgaJpZM4JeV9g
.

[svozza]

Yep, makes sense. Looking at the Fantasy Land spec though it looks like of needs to be on the object's prototype so we'll have to revisit this later anyway:

https://github.com/fantasyland/fantasy-land#of-method