[BREAKING] Make take/drop/slice to validate their arguments and throw an appropriate error. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vqvu
force-pushed
the
type-check-all-the-things
branch
from
ef83353
to
7b419a3
Compare
… an appropriate error. Changes: - Throws a TypeError if arguments are not a number. slice arguments are allowed to be null. In which case, they default to reasonable values. - Throws a RangeError if arguments are negative. Also adds support for - `@throws` in docs. - markdown in `@param` description. - Talk about optional arguments in curried functions.
vqvu
force-pushed
the
type-check-all-the-things
branch
from
7b419a3
to
bafdea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
allowed to be null. In which case, they default to reasonable values.
Also adds support for
@throwsin docs.@paramdescription.Ref #594.