Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created subscribe method for Observable spec compatibility #672

Closed
wants to merge 15 commits into from
Closed

Created subscribe method for Observable spec compatibility #672

wants to merge 15 commits into from

Commits on Feb 27, 2019

  1. Created subscribe method for RxJS\Observable compatibility

    @jaidetree
    jaidetree committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    6e66ac3 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Implemented subscribe according to observable spec 

    caolan#672
    @jaidetree
    jaidetree committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    0831bdc View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Added Symbol.observable support

    @jaidetree
    jaidetree committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    2a4f121 View commit details
    Browse the repository at this point in the history

  2. Credit RxJS as source of observable symbol resolution

    @jaidetree
    jaidetree committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    934daab View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. Pull review requested changes for caolan#672 

    Resolves comments:
caolan#672 (comment)
caolan#672 (comment)
caolan#672 (comment)
caolan#672 (comment)
    @jaidetree
    jaidetree committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    48fa72a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2019

  1. Fixed subscribe method PR requested changes 

    Steps:

- caolan#672 (comment)
- caolan#672 (comment)
- caolan#672 (comment)
    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    a1edb49 View commit details
    Browse the repository at this point in the history

  2. Fixed subscribe tests when subscribing to completed stream

    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    01e7783 View commit details
    Browse the repository at this point in the history

  3. Tests for observableSubscription behavior

    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    890aa05 View commit details
    Browse the repository at this point in the history

  4. Finished first draft of observableSubscription

    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    f2dae55 View commit details
    Browse the repository at this point in the history

  5. Added more documentation to observableSubscription

    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    7a053ae View commit details
    Browse the repository at this point in the history

  6. Update ObservableSubscription for PR requested changes: 

    Requested Changes:
- caolan#672 (comment)
- caolan#672 (comment)
- caolan#672 (comment)
- caolan#672 (comment)
    @jaidetree
    jaidetree committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    ffbb15a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. Fixed subscribe PR changes in caolan#672 

    PR Comments:
- caolan#672 (comment)
    @jaidetree
    jaidetree committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    fb7c149 View commit details
    Browse the repository at this point in the history

  2. Fixed lint error in subscribe method

    @jaidetree
    jaidetree committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    1be35e9 View commit details
    Browse the repository at this point in the history

  3. Fixed subscribe PR requested changes 

    Requested Changes:
- caolan#672 (comment)
- caolan#672 (review)
    @jaidetree
    jaidetree committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    5ca90ae View commit details
    Browse the repository at this point in the history

  4. Submit method PR requested changes 

    Requested Changes:
- caolan#672 (comment)
- caolan#672 (comment)
- caolan#672 (comment)
    @jaidetree
    jaidetree committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    a2a3b25 View commit details
    Browse the repository at this point in the history