takeWhile(f) added, issues #378, #675 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vqvu
requested changes
Mar 26, 2019
lib/index.js
Outdated
| catch (e) { | ||
| fnErr = e; | ||
| } | ||
| if (fnVal) { |
There was a problem hiding this comment.
Reverse this.
if (fnErr) {
...
next();
} else if (fnVal) {
...
next();
} else {
push(null, nil);
}
You want to check for fnErr first, since you need to push nil if fnVal is false.
lib/index.js
Outdated
| * @throws {TypeError} if `f` is not a function. | ||
| * @api public | ||
| * | ||
| * _([1, 2, 3, 4]).takeWhile(x => x<3) // => 1, 2 |
There was a problem hiding this comment.
Suggested change
| * _([1, 2, 3, 4]).takeWhile(x => x<3) // => 1, 2 | |
| * _([1, 2, 3, 4]).takeWhile(x => x < 3) // => 1, 2 |
vqvu
requested changes
Mar 27, 2019
There was a problem hiding this comment.
Please also add an entry to the CHANGELOG.md for 3.0.0-beta.10. Use the format of the previous entries.
Co-Authored-By: mauriciocap <mauriciocap@gmail.com>
…hland into takeWhile_from_issue_378
vqvu
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #675 and #378