Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the rest function #85

Merged
merged 0 commits into from
Nov 24, 2014
Merged

added the rest function #85

merged 0 commits into from
Nov 24, 2014

Conversation

greelgorke
Copy link
Collaborator

this could solve the requirements in #81

PS: first intention was to name it cdr, since head is car 👅

@greelgorke
Copy link
Collaborator Author

i've seen #75, which is basically this solving #11. also what is the difference between #11 and #12? is it just the parameter?

cc @caolan @alexanderbeletsky

@alexbeletsky
Copy link
Contributor

In my opinion, .take() and .drop() already solves that problem.. what would be the value in .skip() and .rest() ?

@greelgorke
Copy link
Collaborator Author

in fact drop and rest do the same, just that rest in this PR has a default behavior of tail. however, i think there should be some resolving. i'm ok with getting my PR back, when it's unnecessary.

@caolan
Copy link
Owner

caolan commented May 23, 2014

@greelgorke I think we should add a .tail() or .rest() but have it accept no arguments and only be equivalent to drop(1). Optional arguments don't play nicely with Highland's currying-by-default API.

@greelgorke
Copy link
Collaborator Author

ok. then, i guess i'll wait till #75 got merged and then wrap it in .tail()/.rest()

btw. the travis failes to install on node 0.8, not sure why exactly

@caolan
Copy link
Owner

caolan commented May 23, 2014

btw, I'm also a fan of car / cdr, but not sure that's as widely used ;)

@apaleslimghost
Copy link
Collaborator

Build is failing on 0.8. I think current master drops 0.8 on Travis, can you rebase it @greelgorke?

@vqvu vqvu merged commit 660d877 into caolan:master Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants