JUnit reporter does not output time #275 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert curModule.testcases from array to dictionary; - Set 'start' end 'end' at suites and testcases;
- Using suites as dictionary; - Using start, end to print time attributes in testsuite and testcase.
|
+1 I've been wanting this! |
| @@ -108,13 +108,21 @@ exports.run = function (files, opts, callback) { | |||
| errorCount: 0, | |||
| failureCount: 0, | |||
| tests: 0, | |||
| testcases: [], | |||
| name: name | |||
| testcases: {}, | |||
There was a problem hiding this comment.
@hugosenari sorry this took so long. Why converting from array to dictionary here?
There was a problem hiding this comment.
Because is more easy to find them again later at testDone
|
Any hope for this being merged? It'd be useful for our legacy project which uses nodeunit on circle-ci. |
|
Awesome! Could we get a publish, too? |
iminyukov
pushed a commit
to iminyukov/nodeunit
that referenced
this pull request
Apr 23, 2018
JUnit reporter does not output time caolan#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation, that works.