perf: optimize session variables in HANA (#339)

Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
cap-js · Nov 10, 2023 · 4240c58 · 4240c58
1 parent 4c948fe
commit 4240c58
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/hana/lib/HANAService.js b/hana/lib/HANAService.js
@@ -64,12 +64,7 @@ class HANAService extends SQLService {
  }
 
  async set(variables) {
- const columns = Object.keys(variables).map(
- k => `SET '${k.replace(/'/g, "''")}'='${(variables[k] + '').replace(/'/g, "''")}';`,
- )
- const sql = `DO BEGIN ${columns.join('')} END;`
-
- await this.dbc.exec(sql)
+ this.dbc.set(variables)
  }
 
  async onSELECT({ query, data }) {

diff --git a/hana/lib/drivers/base.js b/hana/lib/drivers/base.js
@@ -90,6 +90,11 @@ class HANADriver {
  return prom(this._native, 'exec')(sql)
  }
 
+ set(variables) {
+ variables
+ throw new Error('Implementation missing')
+ }
+
  /**
  * Commits the current transaction
  */

diff --git a/hana/lib/drivers/hana-client.js b/hana/lib/drivers/hana-client.js
@@ -19,6 +19,10 @@ class HANAClientDriver extends driver {
  this._native.setAutoCommit(false)
  }
 
+ set(variables) {
+ Object.keys(variables).forEach(k => this._native.setClientInfo(k, variables[k]))
+ }
+
  async prepare(sql) {
  const ret = await super.prepare(sql)
  ret.stream = async (values, one) => {

diff --git a/hana/lib/drivers/hdb.js b/hana/lib/drivers/hdb.js
@@ -26,6 +26,11 @@ class HDBDriver extends driver {
  this.connected = false
  }
 
+ set(variables) {
+ const clientInfo = this._native._connection.getClientInfo()
+ Object.keys(variables).forEach(k => clientInfo.setProperty(k, variables[k]))
+ }
+
  async prepare(sql) {
  const ret = await super.prepare(sql)
  ret.stream = async (values, one) => {