fix: ignore empty order by (#392)

cap-js · Dec 20, 2023 · a69fed0 · a69fed0
1 parent 450db36
commit a69fed0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hana/lib/HANAService.js b/hana/lib/HANAService.js
@@ -315,7 +315,7 @@ class HANAService extends SQLService {
         const over = { xpr: [] }
         // TODO: replace with full path partitioning
         if (parent) over.xpr.push(`PARTITION BY ${this.ref({ ref: ['_parent_path_'] })}`)
-        if (orderBy) over.xpr.push(` ORDER BY ${this.orderBy(orderBy, localized)}`)
+        if (orderBy?.length) over.xpr.push(` ORDER BY ${this.orderBy(orderBy, localized)}`)
         const rn = { xpr: [{ func: 'ROW_NUMBER', args: [] }, 'OVER', over], as: '$$RN$$' }
         q.as = q.SELECT.from.as