fix: Disconnect db service on shutdown #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
patricebender
approved these changes
Nov 2, 2023
| @@ -6,6 +6,12 @@ const cds = require('@sap/cds/lib') | |||
| /** @typedef {unknown} DatabaseDriver */ | |||
|
|
|||
| class DatabaseService extends cds.Service { | |||
|
|
|||
| init() { | |||
| cds.on('shutdown', () => this.disconnect()) | |||
There was a problem hiding this comment.
We might need to implement something that disconnects all tenant pools in multitenancy mode. Something like disconnect('*')
There was a problem hiding this comment.
disconnect(undefined) should match all tenants. Will update the disconnect function to just go over all pools.
johannes-vogel
approved these changes
Nov 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with
HANAandPostgresthe service does not disconnect with the defaultcds.test. So this registers thedisconnectfunction to theshutdownevent.